Bug 177513

Summary: Expose setShouldSuppressFirstResponderChanges() as WKView SPI
Product: WebKit Reporter: iting_liu
Component: WebKit APIAssignee: iting_liu
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, iting_liu, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1.
wenson_hsieh: review+
Patch v2. Added WK_API_AVAILABLE.
none
V3. none

iting_liu
Reported 2017-09-26 15:56:42 PDT
Safari is still using WKView, so even though we already have such SPI on WKWebView, we still need one for WKView.
Attachments
Patch v1. (2.84 KB, patch)
2017-09-26 16:36 PDT, iting_liu 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch v2. Added WK_API_AVAILABLE. (2.88 KB, patch)
2017-09-27 13:04 PDT, iting_liu 		no flags
DetailsFormatted DiffDiff
V3. (2.88 KB, patch)
2017-09-27 13:20 PDT, iting_liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
iting_liu
Comment 1 2017-09-26 15:58:35 PDT
<rdar://problem/34669220> Allow calling WebViewImpl::setShouldSuppressFirstResponderChanges from WKView and iOS WKWebView
iting_liu
Comment 2 2017-09-26 16:36:02 PDT
Created attachment 321889 [details] Patch v1.
Wenson Hsieh
Comment 3 2017-09-27 11:29:44 PDT
Comment on attachment 321889 [details] Patch v1. View in context: https://bugs.webkit.org/attachment.cgi?id=321889&action=review > Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:135 > +- (void)_setShouldSuppressFirstResponderChanges:(BOOL)shouldSuppress; We should add an availability macro here (even if it's missing from most of the surrounding SPI :/)
iting_liu
Comment 4 2017-09-27 13:01:13 PDT
Comment on attachment 321889 [details] Patch v1. View in context: https://bugs.webkit.org/attachment.cgi?id=321889&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:135 >> +- (void)_setShouldSuppressFirstResponderChanges:(BOOL)shouldSuppress; > > We should add an availability macro here (even if it's missing from most of the surrounding SPI :/) I'll add WK_API_AVAILABLE(macosx(WK_MAC_TBA)) here as we discussed.
iting_liu
Comment 5 2017-09-27 13:04:31 PDT
Created attachment 322007 [details] Patch v2. Added WK_API_AVAILABLE.
iting_liu
Comment 6 2017-09-27 13:20:40 PDT
Created attachment 322011 [details] V3. Updated "Reviewed by"
WebKit Commit Bot
Comment 7 2017-09-27 14:44:23 PDT
Comment on attachment 322011 [details] V3. Clearing flags on attachment: 322011 Committed r222577: <http://trac.webkit.org/changeset/222577>
WebKit Commit Bot
Comment 8 2017-09-27 14:44:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-09-27 15:20:06 PDT
<rdar://problem/34699348>
Note You need to log in before you can comment on or make changes to this bug.