Bug 177511

Summary: Make it possible to easily get verbose ninja output from build-webkit
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, dbates, keith_miller, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177512    
Attachments:
Description Flags
Patch sam: review+

Tim Horton
Reported 2017-09-26 15:33:35 PDT
Make it possible to easily get verbose ninja output from build-webkit
Attachments
Patch (4.16 KB, patch)
2017-09-26 15:33 PDT, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-09-26 15:33:49 PDT
Created attachment 321880 [details] Patch
Sam Weinig
Comment 2 2017-09-26 17:03:56 PDT
Comment on attachment 321880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321880&action=review Seems fine. Kind of weird using ENV to communicate to buildCMakeGeneratedProject. Seems like passing an argument would be clearer. > Tools/ChangeLog:15 > + Add Ninja verbosity arguments to @makeArgs, which are appended > + after the -- and thus handed to ninja; the previous implementation Inconsistent on capitalization of Ninja.
Tim Horton
Comment 3 2017-09-26 18:00:47 PDT
https://trac.webkit.org/changeset/222538/webkit
Radar WebKit Bug Importer
Comment 4 2017-09-27 12:14:43 PDT
<rdar://problem/34692854>
Note You need to log in before you can comment on or make changes to this bug.