Bug 177502

Summary: AX: Several ARIA roles with presentational children are exposing children
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jlewis3, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
original patch with updated results inspector test none

Joanmarie Diggs
Reported 2017-09-26 13:26:52 PDT
The following ARIA roles have presentational children (and thus should not include those children in the accessibility tree): * menuitemcheckbox (a 1.1 change) * menuitemradio (a 1.1 change) * separator * math We're exposing the children.
Attachments
Patch (6.04 KB, patch)
2017-09-26 13:42 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
original patch with updated results inspector test (6.58 KB, patch)
2017-09-26 17:41 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-09-26 13:27:17 PDT
<rdar://problem/34665059>
Joanmarie Diggs
Comment 2 2017-09-26 13:42:08 PDT
Created attachment 321862 [details] Patch
WebKit Commit Bot
Comment 3 2017-09-26 14:51:07 PDT
Comment on attachment 321862 [details] Patch Clearing flags on attachment: 321862 Committed r222525: <http://trac.webkit.org/changeset/222525>
WebKit Commit Bot
Comment 4 2017-09-26 14:51:09 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 5 2017-09-26 16:40:43 PDT
This caused the test inspector/dom/getAccessibilityPropertiesForNode.html to start failing consistently on macOS: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdom%2FgetAccessibilityPropertiesForNode.html build results: https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r222525%20(4747)/results.html diff: --- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-actual.txt @@ -484,7 +484,6 @@ exists: true label: role: separator - childNodeIds.length: 1 parentNodeId: exists <div role="doc-notice">doc-notice</div>
Matt Lewis
Comment 6 2017-09-26 16:59:18 PDT
Reverted r222525 for reason: This caused a consistent failure in the test inspector/dom/getAccessibilityPropertiesForNode.html . Committed r222535: <http://trac.webkit.org/changeset/222535>
Joanmarie Diggs
Comment 7 2017-09-26 17:08:54 PDT
Ouch. Sorry I missed your IRC ping. Especially given your quick rollout. :( But that test just needs to be rebased. New patch coming up....
Joanmarie Diggs
Comment 8 2017-09-26 17:41:41 PDT
Created attachment 321909 [details] original patch with updated results inspector test
WebKit Commit Bot
Comment 9 2017-09-26 19:21:15 PDT
Comment on attachment 321909 [details] original patch with updated results inspector test Clearing flags on attachment: 321909 Committed r222544: <http://trac.webkit.org/changeset/222544>
WebKit Commit Bot
Comment 10 2017-09-26 19:21:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.