Bug 177480

Summary: Make PolicyAction an encodable enum class
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, dbates, japhet, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2017-09-25 21:48:21 PDT
Make PolicyAction an encodable enum class
Attachments
Patch (40.93 KB, patch)
2017-09-25 21:56 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (41.09 KB, patch)
2017-09-25 22:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-25 21:56:25 PDT
Created attachment 321789 [details] Patch
Antti Koivisto
Comment 2 2017-09-25 22:00:19 PDT
Comment on attachment 321789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321789&action=review > Source/WebKit/UIProcess/WebPageProxy.messages.in:102 > + DecidePolicyForNavigationAction(uint64_t frameID, struct WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, struct WebKit::NavigationActionData navigationActionData, struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest originalRequest, WebCore::ResourceRequest request, uint64_t listenerID, WebKit::UserData userData) -> (uint64_t newNavigationID, enum WebCore::PolicyAction policyAction, WebKit::DownloadID downloadID, struct WebKit::WebsitePolicies websitePolicies) Delayed Would be nice make these sane at some point (by packing all the million arguments into a struct for example).
Antti Koivisto
Comment 3 2017-09-25 22:00:31 PDT
r=me
Alex Christensen
Comment 4 2017-09-25 22:28:53 PDT
Created attachment 321795 [details] Patch
Alex Christensen
Comment 5 2017-09-25 22:52:59 PDT
http://trac.webkit.org/r222492
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:15:55 PDT
<rdar://problem/34692891>
Note You need to log in before you can comment on or make changes to this bug.