Bug 177479

Summary: [WinCairo] Share default value of font family preferences among non-cocoa builds
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, don.olmstead, stephan.szabo, webkit-bug-importer, yoshiaki.jitsukawa, Yousuke.Kimoto, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yoshiaki Jitsukawa
Reported 2017-09-25 18:59:43 PDT
Currently the default font family preferences are defined for PLATFORM(COCOA) and (PLATFORM(GTK) || PLATFORM(WPE)) and there's no definitions for the other ports. It seems like we can use (PLATFORM(GTK) || PLATFORM(WPE))'s one as a default case. #if PLATFORM(COCOA) #define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \ macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \ macro(CursiveFontFamily, cursiveFontFamily, String, String, DEFAULT_CURSIVE_FONT_FAMILY, "", "") \ macro(FantasyFontFamily, fantasyFontFamily, String, String, "Papyrus", "", "") \ macro(FixedFontFamily, fixedFontFamily, String, String, "Courier", "", "") \ macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \ macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \ macro(PictographFontFamily, pictographFontFamily, String, String, "Apple Color Emoji", "", "") \ \ #elif PLATFORM(GTK) || PLATFORM(WPE) #define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \ macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \ macro(CursiveFontFamily, cursiveFontFamily, String, String, "Comic Sans MS", "", "") \ macro(FantasyFontFamily, fantasyFontFamily, String, String, "Impact", "", "") \ macro(FixedFontFamily, fixedFontFamily, String, String, "Courier New", "", "") \ macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \ macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \ macro(PictographFontFamily, pictographFontFamily, String, String, "Times", "", "") \ \ #endif
Attachments
Patch (1.31 KB, patch)
2017-09-25 19:39 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2017-09-25 19:39:42 PDT
Created attachment 321786 [details] Patch
Yusuke Suzuki
Comment 2 2017-09-25 21:18:10 PDT
Comment on attachment 321786 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-09-25 21:56:14 PDT
Comment on attachment 321786 [details] Patch Clearing flags on attachment: 321786 Committed r222490: <http://trac.webkit.org/changeset/222490>
WebKit Commit Bot
Comment 4 2017-09-25 21:56:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:16:03 PDT
<rdar://problem/34692895>
Note You need to log in before you can comment on or make changes to this bug.