| Summary: | WebAssembly: no VM / JS version of our implementation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||||
| Component: | WebAssembly | Assignee: | JF Bastien <jfbastien> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, rniwa, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 177473, 178690, 178738 | ||||||||
| Bug Blocks: | 177475, 170260, 176644 | ||||||||
| Attachments: |
|
||||||||
|
Description
JF Bastien
2017-09-25 16:16:29 PDT
*** Bug 170260 has been marked as a duplicate of this bug. *** Created attachment 324959 [details]
patch
Attachment 324959 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/wasm/WasmInstance.h:45: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/wasm/WasmInstance.h:45: The parameter name "module" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/wasm/WasmInstance.h:107: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:63: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:71: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 5 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 324959 [details] patch Attachment 324959 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4994475 Number of test failures exceeded the failure limit. Created attachment 324965 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Test failures seem unrelated. Failures all seem to be server errors when the tests ran. Comment on attachment 324959 [details]
patch
r=me
Comment on attachment 324959 [details] patch Clearing flags on attachment: 324959 Committed r224020: <https://trac.webkit.org/changeset/224020> All reviewed patches have been landed. Closing bug. |