Bug 177472

Summary: WebAssembly: no VM / JS version of our implementation
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: WebAssemblyAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 177473, 178690, 178738    
Bug Blocks: 177475, 170260, 176644    
Attachments:
Description Flags
patch
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 none

JF Bastien
Reported 2017-09-25 16:16:29 PDT
It should be possible to use our JSC WebAssembly implementation without having a VM or JS.
Attachments
patch (70.12 KB, patch)
2017-10-25 22:49 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (845.31 KB, application/zip)
2017-10-25 23:32 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-10-25 22:30:03 PDT
*** Bug 170260 has been marked as a duplicate of this bug. ***
JF Bastien
Comment 2 2017-10-25 22:49:29 PDT
Created attachment 324959 [details] patch
Build Bot
Comment 3 2017-10-25 22:51:51 PDT
Attachment 324959 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmInstance.h:45: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/wasm/WasmInstance.h:45: The parameter name "module" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/wasm/WasmInstance.h:107: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:63: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:71: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4 2017-10-25 23:32:44 PDT
Comment on attachment 324959 [details] patch Attachment 324959 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4994475 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2017-10-25 23:32:45 PDT
Created attachment 324965 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
JF Bastien
Comment 6 2017-10-26 08:08:01 PDT
Test failures seem unrelated.
JF Bastien
Comment 7 2017-10-26 08:18:33 PDT
Failures all seem to be server errors when the tests ran.
Michael Saboff
Comment 8 2017-10-26 08:21:06 PDT
Comment on attachment 324959 [details] patch r=me
WebKit Commit Bot
Comment 9 2017-10-26 08:33:59 PDT
Comment on attachment 324959 [details] patch Clearing flags on attachment: 324959 Committed r224020: <https://trac.webkit.org/changeset/224020>
WebKit Commit Bot
Comment 10 2017-10-26 08:34:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2017-11-15 13:10:51 PST
<rdar://problem/35568917>
Note You need to log in before you can comment on or make changes to this bug.