Bug 177458

Summary: Followup (r222427): SynchronizedFixedQueue should not have a public constructor
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, darin, dbates, ddkilzer, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=177406
Attachments:
Description Flags
Patch
none
Patch none

Description Said Abou-Hallawa 2017-09-25 13:05:31 PDT
Since SynchronizedFixedQueue is now derived from ThreadSafeRefCounted<SynchronizedFixedQueue>, the standard way to have an instance of it is to call SynchronizedFixedQueue::create() which returns a Ref<SynchronizedFixedQueue>. Now it does not make since to still have the constructor public.
Comment 1 Said Abou-Hallawa 2017-09-25 13:12:26 PDT
Created attachment 321730 [details]
Patch
Comment 2 Tim Horton 2017-09-26 14:43:43 PDT
Comment on attachment 321730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321730&action=review

> Source/WTF/ChangeLog:10
> +        which returns a Ref<SynchronizedFixedQueue>. Now it does not make since to still

s/since/sense/
Comment 3 Said Abou-Hallawa 2017-09-26 15:13:53 PDT
Created attachment 321878 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-26 15:40:54 PDT
Comment on attachment 321878 [details]
Patch

Clearing flags on attachment: 321878

Committed r222530: <http://trac.webkit.org/changeset/222530>
Comment 5 WebKit Commit Bot 2017-09-26 15:40:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:17:50 PDT
<rdar://problem/34692977>