Bug 177455

Summary: Make StoredCredentials an enum class and rename its header
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, ggaren, koivisto, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177474    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2017-09-25 12:29:11 PDT 
Make StoredCredentials an enum class and rename its header for clarity. This was error-prone because 0 meant "allow" and and 1 meant "do not allow". It was trivial to convert it to a boolean by mistake and get the opposite behavior.
Comment 1 Chris Dumez 2017-09-25 12:31:49 PDT 
Created attachment 321720 [details]
Patch
Comment 2 WebKit Commit Bot 2017-09-25 14:17:48 PDT 
Comment on attachment 321720 [details]
Patch

Clearing flags on attachment: 321720

Committed r222467: <http://trac.webkit.org/changeset/222467>
Comment 3 WebKit Commit Bot 2017-09-25 14:17:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Dumez 2017-09-26 09:59:34 PDT 
Forgot enum *class*.
Comment 5 Chris Dumez 2017-09-26 10:02:47 PDT 
Created attachment 321830 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-26 13:36:33 PDT 
Comment on attachment 321830 [details]
Patch

Clearing flags on attachment: 321830

Committed r222519: <http://trac.webkit.org/changeset/222519>
Comment 7 WebKit Commit Bot 2017-09-26 13:36:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:18:04 PDT 
<rdar://problem/34692984>