Bug 177431

Summary: Update compressedTexImage3D to match the signature in the specification.
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: WebGLAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2017-09-25 06:56:00 PDT
.
Attachments
Patch (5.02 KB, patch)
2017-09-25 07:03 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Patch (4.92 KB, patch)
2017-09-26 00:44 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-09-25 07:03:30 PDT
Created attachment 321680 [details] Patch
Sam Weinig
Comment 2 2017-09-25 16:58:26 PDT
Comment on attachment 321680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321680&action=review > Source/WebCore/html/canvas/WebGL2RenderingContext.h:76 > + void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, RefPtr<ArrayBufferView>&& srcData, GC3Duint srcOffset, GC3Duint srcLengthOverride); The ArrayBuffer can probably be a ArrayBufferView&, since the IDL parameter is not nullable.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 3 2017-09-26 00:44:26 PDT
Created attachment 321806 [details] Patch
WebKit Commit Bot
Comment 4 2017-09-26 01:13:42 PDT
Comment on attachment 321806 [details] Patch Clearing flags on attachment: 321806 Committed r222496: <http://trac.webkit.org/changeset/222496>
WebKit Commit Bot
Comment 5 2017-09-26 01:13:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:17:12 PDT
<rdar://problem/34692943>
Note You need to log in before you can comment on or make changes to this bug.