Bug 177427

Summary: Support building JavaScriptCore with the Bionic C library
Product: WebKit Reporter: Zan Dobersek <zan>
Component: JavaScriptCoreAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, dbates, fpizlo, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2017-09-25 01:40:51 PDT
The Bionic C library doesn't define __GLIBC__ macro like some other non-GNU C libraries, so the __BIONIC__ macro has to be handled in parallel.
Attachments
Patch (4.26 KB, patch)
2017-09-25 04:23 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-09-25 04:23:57 PDT
Created attachment 321677 [details] Patch
Michael Catanzaro
Comment 2 2017-09-25 07:20:16 PDT
Comment on attachment 321677 [details] Patch If this is all that's needed to get JSC working properly, then OK. It's clearly no maintenance burden.
Zan Dobersek
Comment 3 2017-09-26 00:07:48 PDT
Comment on attachment 321677 [details] Patch Clearing flags on attachment: 321677 Committed r222495: <http://trac.webkit.org/changeset/222495>
Zan Dobersek
Comment 4 2017-09-26 00:07:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:17:05 PDT
<rdar://problem/34692940>
Note You need to log in before you can comment on or make changes to this bug.