Bug 177421

Summary:

JSC build should use unified sources for derived sources

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, ggaren, jfbastien, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Try without JSCBuiltins	none
Patch	jfbastien: review+

Keith Miller

Reported 2017-09-24 18:48:34 PDT

JSC build should use unified sources for derived sources

Attachments
Patch (65.58 KB, patch) 2017-09-24 18:55 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Try without JSCBuiltins (67.51 KB, patch) 2017-09-26 07:15 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (68.47 KB, patch) 2017-09-26 08:16 PDT, Keith Miller	jfbastien: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2017-09-24 18:55:28 PDT

Created attachment 321662 [details] Patch

Keith Miller

Comment 2 2017-09-24 18:57:50 PDT

I chose to not have any special marking to describe derived sources in our Sources.txt files since it seemed unnecessary. I considered prefixing them with a * but I figured that would just be confusing. Having a general rule about putting a comment stating a source is derived would be sufficient.

Keith Miller

Comment 3 2017-09-25 09:35:10 PDT

Comment on attachment 321662 [details] Patch Looks like windows build is broken.

Keith Miller

Comment 4 2017-09-26 07:15:37 PDT

Created attachment 321813 [details] Try without JSCBuiltins

Keith Miller

Comment 5 2017-09-26 08:16:33 PDT

Created attachment 321816 [details] Patch

JF Bastien

Comment 6 2017-09-26 08:23:19 PDT

Comment on attachment 321816 [details] Patch r=me