| Summary: | JSC build should use unified sources for derived sources | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, aestes, ggaren, jfbastien, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Keith Miller
2017-09-24 18:48:34 PDT
Created attachment 321662 [details]
Patch
I chose to not have any special marking to describe derived sources in our Sources.txt files since it seemed unnecessary. I considered prefixing them with a * but I figured that would just be confusing. Having a general rule about putting a comment stating a source is derived would be sufficient. Comment on attachment 321662 [details]
Patch
Looks like windows build is broken.
Created attachment 321813 [details]
Try without JSCBuiltins
Created attachment 321816 [details]
Patch
Comment on attachment 321816 [details]
Patch
r=me
Committed r222499: <http://trac.webkit.org/changeset/222499> |