Bug 177411 – REGRESSION(r214201): WebProcess hangs during policy decisions

• Component: New Bugs
• Status: REOPENED

[Alex Christensen]

REGRESSION(r214201): WebProcess hangs during policy decisions

[Alex Christensen]

Created attachment 321641 [details]
Patch

[Geoffrey Garen]

Comment on attachment 321641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321641&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:3756
> +    m_decidePolicyForResponseRequest = 0;

Should be nullptr.

Why did m_decidePolicyForResponseRequest change to a pointer?

[Alex Christensen]

That's how it used to be.  It was an awful mess.

[Alex Christensen]

https://trac.webkit.org/r222431

[Alex Christensen]

http://trac.webkit.org/r222453

[Radar WebKit Bug Importer]

<rdar://problem/34693061>

[Alex Christensen]

Reopening to attach new patch.

[Alex Christensen]

Created attachment 323042 [details]
Patch

The API must behave consistently across platforms and correctly on all platforms.

[Alex Christensen]

(In reply to mitz from comment #9)
> The API must behave consistently across platforms and correctly on all
> platforms.
I agree wholeheartedly.  Unfortunately, that would require https://bugs.webkit.org/show_bug.cgi?id=160677 to land to allow us to wait during redirects and that's WAAAAY too risky for the branch.

(In reply to Alex Christensen from comment #10)
> (In reply to mitz from comment #9)
> > The API must behave consistently across platforms and correctly on all
> > platforms.
> I agree wholeheartedly.  Unfortunately, that would require
> https://bugs.webkit.org/show_bug.cgi?id=160677 to land to allow us to wait
> during redirects and that's WAAAAY too risky for the branch.

Not at all. Your change log says “[…] Mac, which depends on the ability to asynchronously call the completion handlers” but that’s incorrect. There is only one client of the API on macOS that, because it adapted to the changes introduced in r214201, depends on that behavior. All other software expects and works with the long-standing behavior of the API as it was prior to r214201 on all platforms. That behavior must be reinstated. Because one client has come to depend on incorrect behavior, that one client can be accommodated by maintaining the some of all of the incorrect behavior as needed for that client.