Bug 177407

Summary: test262: $.agent became $262.agent in test262 update
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-09-23 02:01:13 PDT
test262: $.agent became $262.agent in test262 update Oops. For now I'll expose both `$` and `$262` in jsc, and then transition away from $ (used in a few of our tests).
Attachments
[PATCH] Proposed Fix (194.70 KB, patch)
2017-09-23 02:17 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (194.80 KB, patch)
2017-09-23 02:58 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-09-23 02:17:06 PDT
Created attachment 321624 [details] [PATCH] Proposed Fix Not cq yet since I am still running tests with the new expectations file and I might have missed one or two.
Joseph Pecoraro
Comment 2 2017-09-23 02:58:05 PDT
Created attachment 321626 [details] [PATCH] Proposed Fix
Yusuke Suzuki
Comment 3 2017-09-23 03:33:43 PDT
Comment on attachment 321626 [details] [PATCH] Proposed Fix r=me, nice
WebKit Commit Bot
Comment 4 2017-09-23 04:01:06 PDT
Comment on attachment 321626 [details] [PATCH] Proposed Fix Clearing flags on attachment: 321626 Committed r222424: <http://trac.webkit.org/changeset/222424>
WebKit Commit Bot
Comment 5 2017-09-23 04:01:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:18:51 PDT
<rdar://problem/34693007>
Note You need to log in before you can comment on or make changes to this bug.