Bug 177402

Summary: Web Inspector: Reduce work during resizing
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-09-22 18:20:01 PDT
Reduce work during resizing We don't need to refresh CodeMirror in the ConsolePrompt when it is empty. Nothing changes in the prompt but we are spending a bunch of time there under refresh. CodeMirror has its own resize detection as well.
Attachments
[PATCH] Proposed Fix (1.13 KB, patch)
2017-09-22 18:21 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (1.25 KB, patch)
2017-09-22 18:29 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-09-22 18:21:10 PDT
Created attachment 321606 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2017-09-22 18:24:33 PDT
Comment on attachment 321606 [details] [PATCH] Proposed Fix Actually I wonder if we can just remove this.
Joseph Pecoraro
Comment 3 2017-09-22 18:29:45 PDT
Created attachment 321609 [details] [PATCH] Proposed Fix The only case where the refresh() mattered was switching tabs (causing sidebars to go away and the console size to change size). For an empty console we shouldn't need to refresh anything.
Matt Baker
Comment 4 2017-09-24 11:27:13 PDT
Comment on attachment 321609 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2017-09-24 11:55:07 PDT
Comment on attachment 321609 [details] [PATCH] Proposed Fix Clearing flags on attachment: 321609 Committed r222436: <http://trac.webkit.org/changeset/222436>
WebKit Commit Bot
Comment 6 2017-09-24 11:55:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:17:21 PDT
<rdar://problem/34692954>
Note You need to log in before you can comment on or make changes to this bug.