Bug 177387

Summary: Web Inspector: Remove SidebarPanel show/hide and added/removed
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Matt Baker
Reported 2017-09-22 15:06:40 PDT
These are not being used, and just contribute to view lifecycle noise (show, hide, shown, hidden, closed).
Attachments
Patch (2.65 KB, patch)
2017-09-22 15:08 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (5.04 KB, patch)
2017-09-22 16:02 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-09-22 15:08:12 PDT
Created attachment 321594 [details] Patch
Matt Baker
Comment 2 2017-09-22 16:01:23 PDT
SidebarPanel.prototype.show/hide just set the selected panel and collapsed/uncollapsed the sidebar. `hide` was unused, and `show` was only used in two special cases. These methods provided no functionality beyond what can easily be accomplished via the Sidebar, and were confusing due to their similarity to shown/hidden.
Matt Baker
Comment 3 2017-09-22 16:02:57 PDT
Created attachment 321599 [details] Patch
Devin Rousso
Comment 4 2017-09-22 16:52:33 PDT
Comment on attachment 321599 [details] Patch r=me
WebKit Commit Bot
Comment 5 2017-09-22 17:55:27 PDT
Comment on attachment 321599 [details] Patch Clearing flags on attachment: 321599 Committed r222420: <http://trac.webkit.org/changeset/222420>
WebKit Commit Bot
Comment 6 2017-09-22 17:55:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:21:01 PDT
<rdar://problem/34693102>
Note You need to log in before you can comment on or make changes to this bug.