Bug 177379

Summary: Web Inspector: NavigationBar should coalesce consecutive dividers when items are hidden
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2017-09-22 13:17:47 PDT
Summary: NavigationBar should coalesce consecutive dividers when items are hidden. Currently this is only done when items are forced hidden when collapsing the bar to fit the available space. We should always coalesce dividers during a layout, since hiding items (NavigationItem.prototype.hidden) can also cause dividers to pile up.
Attachments
Patch (2.61 KB, patch)
2017-09-22 13:19 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-09-22 13:19:02 PDT
Created attachment 321587 [details] Patch
Joseph Pecoraro
Comment 2 2017-09-22 13:39:49 PDT
Comment on attachment 321587 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-09-22 14:08:31 PDT
Comment on attachment 321587 [details] Patch Clearing flags on attachment: 321587 Committed r222405: <http://trac.webkit.org/changeset/222405>
WebKit Commit Bot
Comment 4 2017-09-22 14:08:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:18:55 PDT
<rdar://problem/34693012>
Note You need to log in before you can comment on or make changes to this bug.