Bug 177369

Summary: Align Media Source Extension IDL with spec
Product: WebKit Reporter: Nael Ouedraogo <nael.ouedp>
Component: MediaAssignee: Nael Ouedraogo <nael.ouedp>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, mcatanzaro, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nael Ouedraogo
Reported 2017-09-22 10:46:32 PDT
Align Media Source Extension IDL with spec.
Attachments
Patch (3.25 KB, patch)
2017-09-22 10:51 PDT, Nael Ouedraogo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nael Ouedraogo
Comment 1 2017-09-22 10:51:05 PDT
Created attachment 321565 [details] Patch
Sam Weinig
Comment 2 2017-09-22 13:29:31 PDT
Comment on attachment 321565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321565&action=review > Source/WebCore/ChangeLog:9 > + Align IDL as per specification: > + - https://www.w3.org/TR/media-source/ Can you add tests for these (probably only the SourceBuffer.idl one is directly testable actually).
Nael Ouedraogo
Comment 3 2017-09-25 04:59:30 PDT
Thanks for the review. > Can you add tests for these (probably only the SourceBuffer.idl one is > directly testable actually). There is a test (mediasource-remove.html) in WPT that already checks that an exception is thrown when calling remove method with non-finite start values.
WebKit Commit Bot
Comment 4 2017-09-25 05:27:40 PDT
Comment on attachment 321565 [details] Patch Clearing flags on attachment: 321565 Committed r222443: <http://trac.webkit.org/changeset/222443>
WebKit Commit Bot
Comment 5 2017-09-25 05:27:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:17:58 PDT
<rdar://problem/34692980>
Note You need to log in before you can comment on or make changes to this bug.