Summary: | Speedometer: ensure all TodoMVC tests use the complete latest CSS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mathias Bynens <mathias> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | addyo, buildbot, cdumez, commit-queue, mathias, rniwa, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 177359 | ||||||||
Bug Blocks: | 172339 | ||||||||
Attachments: |
|
Description
Mathias Bynens
2017-09-22 05:30:55 PDT
Created attachment 321583 [details]
Patch
Ensuring all implementations use the exact same set of styles cross-browser sgtm. Thanks for catching this, Mathias. Any comparison of perf across browsers before/after this content change? Comment on attachment 321583 [details] Patch Attachment 321583 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4632004 New failing tests: imported/w3c/web-platform-tests/payment-request/payment-request-show-method.https.html Created attachment 321602 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
(In reply to Ryosuke Niwa from comment #3) > Any comparison of perf across browsers before/after this content change? Unfortunately, I haven’t been able to compare the results yet. Can I assume the failing build is a fluke? Yeah, I don't think this can cause a test failure on iOS. Before/after results of the entire Speedometer benchmark: Chrome Canary v63.0.3222.0: 63.55 ± 0.62 (0.98%) → 64.24 ± 0.39 (0.61%) Safari Technology Preview Release 37 (v11.1, WebKit 12605.1.4.0.1): 73.23 ± 0.62 (0.85%) → 73.26 ± 0.66 (0.90%) Firefox Nightly v58.0a1 (2017-09-24) (64-bit): 48.60 ± 0.94 (1.90%) → 48.1 ± 0.62 (1.3%) Turns out the rendering difference didn’t cause much of a difference. Still, it’d be good to fix it. (In reply to Mathias Bynens from comment #8) > Safari Technology Preview Release 37 (v11.1, WebKit 12605.1.4.0.1): That should’ve said Safari Technology Preview Release *39*. The detailed version numbers are correct. Comment on attachment 321583 [details] Patch Clearing flags on attachment: 321583 Committed r222534: <http://trac.webkit.org/changeset/222534> All reviewed patches have been landed. Closing bug. |