Bug 177222

Summary: [PAL] Move MediaTimeAVFoundation into PAL
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yoshiaki Jitsukawa
Reported 2017-09-20 01:40:22 PDT
Move MediaTimeAVFoundation into PAL. This is a blocker to move platform/Clock.
Attachments
Patch (77.48 KB, patch)
2017-09-20 01:51 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (86.14 KB, patch)
2017-09-20 23:36 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2017-09-20 01:51:48 PDT
Created attachment 321302 [details] Patch
Myles C. Maxfield
Comment 2 2017-09-20 11:42:14 PDT
Comment on attachment 321302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321302&action=review > Source/WebCore/Configurations/WebCore.unexp:72 > +__ZNK3WTF9MediaTime9timeValueEv Is this file actually used anymore?
Myles C. Maxfield
Comment 3 2017-09-20 11:42:35 PDT
r=me assuming you get EWS happy
Yoshiaki Jitsukawa
Comment 4 2017-09-20 15:37:56 PDT
(In reply to Myles C. Maxfield from comment #2) > Comment on attachment 321302 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321302&action=review > > > Source/WebCore/Configurations/WebCore.unexp:72 > > +__ZNK3WTF9MediaTime9timeValueEv > > Is this file actually used anymore? Yes, without it I see the following errors: ERROR: WebCore has a weak external symbol in it. ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZNK3WTF9MediaTime14hasBeenRoundedEv ERROR: symbol __ZNK3WTF9MediaTime14hasDoubleValueEv ERROR: symbol __ZNK3WTF9MediaTime18isNegativeInfiniteEv ERROR: symbol __ZNK3WTF9MediaTime18isPositiveInfiniteEv ERROR: symbol __ZNK3WTF9MediaTime7isValidEv ERROR: symbol __ZNK3WTF9MediaTime9timeScaleEv ERROR: symbol __ZNK3WTF9MediaTime9timeValueEv
Yoshiaki Jitsukawa
Comment 5 2017-09-20 23:36:36 PDT
Created attachment 321413 [details] Patch
Yoshiaki Jitsukawa
Comment 6 2017-09-20 23:42:49 PDT
The new PR also adds CoreMediaSoftLink for PAL, to provide "_CMTimeMake" and "_CMTimeMakeWithSeconds".
WebKit Commit Bot
Comment 7 2017-09-21 10:33:56 PDT
Comment on attachment 321413 [details] Patch Clearing flags on attachment: 321413 Committed r222326: <http://trac.webkit.org/changeset/222326>
WebKit Commit Bot
Comment 8 2017-09-21 10:33:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-09-27 12:26:39 PDT
<rdar://problem/34693286>
Note You need to log in before you can comment on or make changes to this bug.