Bug 177207

Summary: Drop legacy DOMError type
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, ggaren, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174573, 177201    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-09-19 15:46:27 PDT
Drop legacy DOMError type. It has been removed from the web platform and replaced with Error / DOMException.
Attachments
Patch (23.78 KB, patch)
2017-09-20 14:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-09-20 14:02:03 PDT
Created attachment 321363 [details] Patch
Eric Carlson
Comment 2 2017-09-20 14:27:26 PDT
Comment on attachment 321363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321363&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:30637 > + E18536841F4E481400FE091B /* WebArchiveResourceFromNSAttributedString.h in Headers */, > + E18C35441F71970C00FF632D /* WebArchiveResourceWebResourceHandler.h in Headers */, Did you mean to include these? > Source/WebCore/WebCore.xcodeproj/project.pbxproj:34415 > + E18536851F50906100FE091B /* WebArchiveResourceFromNSAttributedString.mm in Sources */, > + E18C35431F71970100FF632D /* WebArchiveResourceWebResourceHandler.mm in Sources */, Ditto
Chris Dumez
Comment 3 2017-09-20 14:28:59 PDT
Comment on attachment 321363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321363&action=review >> Source/WebCore/WebCore.xcodeproj/project.pbxproj:30637 >> + E18C35441F71970C00FF632D /* WebArchiveResourceWebResourceHandler.h in Headers */, > > Did you mean to include these? Xcode re-sorted stuff it looks like. The new location looks more correct so I'll keep it.
WebKit Commit Bot
Comment 4 2017-09-20 14:59:23 PDT
Comment on attachment 321363 [details] Patch Clearing flags on attachment: 321363 Committed r222291: <http://trac.webkit.org/changeset/222291>
WebKit Commit Bot
Comment 5 2017-09-20 14:59:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:23:47 PDT
<rdar://problem/34693189>
Note You need to log in before you can comment on or make changes to this bug.