Bug 177189

Summary: Web Inspector: View should automatically layout when attached to the DOM
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2017-09-19 13:45:29 PDT
Summary: A View should automatically layout when it becomes attached to the DOM. Currently a layout has to be scheduled with needsLayout/updateLayout. It shouldn't be possible to have a view attached to the DOM that hasn't had it's initialLayout method called. This is the behavior that 99% of views will want. If the need arises, we can make it possible to opt out with View constructor options or something.
Attachments
Patch (6.96 KB, patch)
2017-09-19 13:56 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-09-19 13:56:17 PDT
Created attachment 321239 [details] Patch
Devin Rousso
Comment 2 2017-09-22 17:01:13 PDT
Comment on attachment 321239 [details] Patch r=me Nice!
WebKit Commit Bot
Comment 3 2017-09-22 17:27:42 PDT
Comment on attachment 321239 [details] Patch Clearing flags on attachment: 321239 Committed r222416: <http://trac.webkit.org/changeset/222416>
WebKit Commit Bot
Comment 4 2017-09-22 17:27:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:21:46 PDT
<rdar://problem/34693128>
Note You need to log in before you can comment on or make changes to this bug.