Bug 177180

Summary: [CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WPE WebKitAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, cgarcia, commit-queue, mcatanzaro, sam, webkit-bug-importer, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172758
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2017-09-19 12:03:47 PDT
On r220445 <https://trac.webkit.org/r172758> the GTK port introduced the public configure option ENABLE_WEB_CRYPTO. The idea is that users pass ENABLE_WEB_CRYPTO instead of ENABLE_SUBTLE_CRYPTO (subtle crypto is a terrible name) I think we should use this naming also on the WPE port to enable SUBTLE crypto. As someone that works on build recipes (Yocto) for WPE and GTK+, I will appreciate to have as much as possible identical config flags for the same features between both ports, to make easier code-sharing of recipe configs So, if both GTK and WPE are going to use this naming then it make sense to mave also the definition to general CMake config like we do with other options
Attachments
Patch (5.48 KB, patch)
2017-09-19 12:18 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-09-19 12:18:54 PDT
Created attachment 321231 [details] Patch
WebKit Commit Bot
Comment 2 2017-09-19 13:42:30 PDT
Comment on attachment 321231 [details] Patch Clearing flags on attachment: 321231 Committed r222222: <http://trac.webkit.org/changeset/222222>
WebKit Commit Bot
Comment 3 2017-09-19 13:42:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.