Bug 177134

Summary: WebDriver: Implement commands to get and set the window rect
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, buildbot, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bburg: review+

Description Carlos Garcia Campos 2017-09-19 06:40:47 PDT
We are currently implementing the selenium legacy ones, we should implement the w3c ones instead.

https://w3c.github.io/webdriver/webdriver-spec.html#resizing-and-positioning-windows
Comment 1 Carlos Garcia Campos 2017-09-19 06:47:09 PDT
Created attachment 321196 [details]
Patch
Comment 2 Build Bot 2017-09-19 06:49:30 PDT
Attachment 321196 [details] did not pass style-queue:


ERROR: Source/WebDriver/WebDriverService.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:90:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:124:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.cpp:786:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.cpp:809:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:639:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:678:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:695:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:712:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:728:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 14 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 BJ Burg 2017-09-19 08:45:03 PDT
Comment on attachment 321196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321196&action=review

r=me

> Source/WebDriver/ChangeLog:13
> +        (WebDriver::Session::getToplevelBrowsingContextRect): Helper to get the window rext. This is used by both get

Nit: 'rect'

> Source/WebDriver/Session.cpp:678
> +void Session::moveToplevelBrowsingContextwindow(double x, double y, Function<void (CommandResult&&)>&& completionHandler)

Nit: 'moveToplevelBrowsingContextWindow'

> Source/WebDriver/Session.cpp:695
> +void Session::resizeToplevelBrowsingContextwindow(double width, double height, Function<void (CommandResult&&)>&& completionHandler)

Ditto.
Comment 4 Carlos Garcia Campos 2017-09-19 23:32:45 PDT
Committed r222256: <http://trac.webkit.org/changeset/222256>
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:29:06 PDT
<rdar://problem/34693357>