Bug 177073

Summary: WebDriver: HTTP responses should include Cache-Control header with no-cache value
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, joepeck, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Description Carlos Garcia Campos 2017-09-18 08:57:19 PDT
6.3 Processing Model
Set the response’s header with name and value with the following values:

Content-Type "application/json; charset=utf-8"
Cache-Control "no-cache"

https://w3c.github.io/webdriver/webdriver-spec.html#dfn-send-a-response
Comment 1 Carlos Garcia Campos 2017-09-18 09:01:02 PDT
Created attachment 321097 [details]
Patch
Comment 2 Sergio Villar Senin 2017-09-18 09:40:38 PDT
Comment on attachment 321097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review

> Source/WebDriver/ChangeLog:9
> +        Set the responseâs header with name and value with the following values:

Weird character here

> Source/WebDriver/soup/HTTPServerSoup.cpp:52
> +                    // §6.3 Processing Model.

Weird character here
Comment 3 Carlos Garcia Campos 2017-09-18 23:39:28 PDT
Comment on attachment 321097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review

Thanks for the review.

>> Source/WebDriver/ChangeLog:9
>> +        Set the responseâs header with name and value with the following values:
> 
> Weird character here

It's the review tool that screws this, open the diff and see it's correct.

>> Source/WebDriver/soup/HTTPServerSoup.cpp:52
>> +                    // §6.3 Processing Model.
> 
> Weird character here

Ditto.
Comment 4 Carlos Garcia Campos 2017-09-18 23:40:11 PDT
Committed r222203: <http://trac.webkit.org/changeset/222203>
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:25:40 PDT
<rdar://problem/34693258>