Bug 177073

Summary: WebDriver: HTTP responses should include Cache-Control header with no-cache value
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, joepeck, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2017-09-18 08:57:19 PDT
6.3 Processing Model Set the response’s header with name and value with the following values: Content-Type "application/json; charset=utf-8" Cache-Control "no-cache" https://w3c.github.io/webdriver/webdriver-spec.html#dfn-send-a-response
Attachments
Patch (2.13 KB, patch)
2017-09-18 09:01 PDT, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-09-18 09:01:02 PDT
Created attachment 321097 [details] Patch
Sergio Villar Senin
Comment 2 2017-09-18 09:40:38 PDT
Comment on attachment 321097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review > Source/WebDriver/ChangeLog:9 > + Set the responseâs header with name and value with the following values: Weird character here > Source/WebDriver/soup/HTTPServerSoup.cpp:52 > + // §6.3 Processing Model. Weird character here
Carlos Garcia Campos
Comment 3 2017-09-18 23:39:28 PDT
Comment on attachment 321097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review Thanks for the review. >> Source/WebDriver/ChangeLog:9 >> + Set the responseâs header with name and value with the following values: > > Weird character here It's the review tool that screws this, open the diff and see it's correct. >> Source/WebDriver/soup/HTTPServerSoup.cpp:52 >> + // §6.3 Processing Model. > > Weird character here Ditto.
Carlos Garcia Campos
Comment 4 2017-09-18 23:40:11 PDT
Committed r222203: <http://trac.webkit.org/changeset/222203>
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:25:40 PDT
<rdar://problem/34693258>
Note You need to log in before you can comment on or make changes to this bug.