Bug 177073 - WebDriver: HTTP responses should include Cache-Control header with no-cache value
Summary: WebDriver: HTTP responses should include Cache-Control header with no-cache v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-18 08:57 PDT by Carlos Garcia Campos
Modified: 2017-09-27 12:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2017-09-18 09:01 PDT, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-09-18 08:57:19 PDT 
6.3 Processing Model
Set the response’s header with name and value with the following values:

Content-Type "application/json; charset=utf-8"
Cache-Control "no-cache"

https://w3c.github.io/webdriver/webdriver-spec.html#dfn-send-a-response
Comment 1 Carlos Garcia Campos 2017-09-18 09:01:02 PDT 
Created attachment 321097 [details]
Patch
Comment 2 Sergio Villar Senin 2017-09-18 09:40:38 PDT 
Comment on attachment 321097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review

> Source/WebDriver/ChangeLog:9
> +        Set the responseâs header with name and value with the following values:

Weird character here

> Source/WebDriver/soup/HTTPServerSoup.cpp:52
> +                    // §6.3 Processing Model.

Weird character here
Comment 3 Carlos Garcia Campos 2017-09-18 23:39:28 PDT 
Comment on attachment 321097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review

Thanks for the review.

>> Source/WebDriver/ChangeLog:9
>> +        Set the responseâs header with name and value with the following values:
> 
> Weird character here

It's the review tool that screws this, open the diff and see it's correct.

>> Source/WebDriver/soup/HTTPServerSoup.cpp:52
>> +                    // §6.3 Processing Model.
> 
> Weird character here

Ditto.
Comment 4 Carlos Garcia Campos 2017-09-18 23:40:11 PDT 
Committed r222203: <http://trac.webkit.org/changeset/222203>
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:25:40 PDT 
<rdar://problem/34693258>