Bug 177054

Summary: Web Inspector: console.assert messages shouldn't end in an exclamation point
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Matt Baker
Reported 2017-09-17 09:48:44 PDT
No need to be so dramatic.
Attachments
Patch (5.53 KB, patch)
2017-09-17 09:50 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.50 KB, patch)
2017-09-18 11:57 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-09-17 09:50:59 PDT
Created attachment 321046 [details] Patch
Joseph Pecoraro
Comment 2 2017-09-18 11:51:08 PDT
Comment on attachment 321046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321046&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Resizer.js:76 > + console.assert(false, `Unexpected Resizer orientation: ${this._orientation}.`); I'd prefer including the orientation as its own parameter instead of an inline string. console.assert(false, "Unexpected Resizer orientation", this._orientation);
Matt Baker
Comment 3 2017-09-18 11:57:42 PDT
Created attachment 321120 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-09-18 12:35:21 PDT
Comment on attachment 321120 [details] Patch for landing Clearing flags on attachment: 321120 Committed r222174: <http://trac.webkit.org/changeset/222174>
WebKit Commit Bot
Comment 5 2017-09-18 12:35:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:25:48 PDT
<rdar://problem/34693261>
Note You need to log in before you can comment on or make changes to this bug.