Bug 176964

Summary:

Create a launcher for webkit-archives

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Lucas Forschler <lforschler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
v1 patch for review	lforschler: commit-queue-
v1 patch for review	aakash_jain: review+, lforschler: commit-queue-

Lucas Forschler

Reported 2017-09-14 15:57:32 PDT

The Apple webkit archives produced by build.webkit.org have no easy way of launching without a WebKit checkout. This bug will track creating a wrapper to be included in the archives such that they can be launched.

Attachments
v1 patch for review (4.03 KB, patch) 2017-09-14 15:59 PDT, Lucas Forschler	lforschler: commit-queue-	Details Formatted Diff Diff
v1 patch for review (4.03 KB, patch) 2017-09-14 16:28 PDT, Lucas Forschler	aakash_jain: review+ lforschler: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-09-14 15:58:05 PDT

<rdar://problem/34445629>

Lucas Forschler

Comment 2 2017-09-14 15:59:33 PDT

Created attachment 320838 [details] v1 patch for review

Lucas Forschler

Comment 3 2017-09-14 16:28:31 PDT

Created attachment 320842 [details] v1 patch for review

Aakash Jain

Comment 4 2017-09-14 16:52:33 PDT

Comment on attachment 320842 [details] v1 patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=320842&action=review > Tools/Scripts/run-webkit-archive:34 > + current_directory = os.path.abspath(os.path.join(script_path,os.pardir)) Is this code to get the directory name? You can probably do current_directory = os.path.dirname(script_path) > Tools/Scripts/run-webkit-archive:41 > + print('No Release or Debug framework directories found, exiting.') This message can use some polishing, maybe specify where are Release or Debug directories not found. > Tools/Scripts/run-webkit-archive:55 > + script_directory = os.path.dirname(script_path) script_directory seems to be unused > Tools/Scripts/run-webkit-archive:61 > + if 'Darwin' not in platform.system(): This code should be made a separate function and called from inside main(). e.g.: check_for_valid_platform()

Lucas Forschler

Comment 5 2017-09-14 17:14:27 PDT

Committed revision 222067.

Note You need to log in before you can comment on or make changes to this bug.