Bug 176954

Summary: Make dumping the graph print when both when exitOK and !exitOK
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2017-09-14 13:41:25 PDT
Currently, we only print when !exitOK. I think it'd be helpful to also print when it's valid to make reading the dump more explicit.
Attachments
patch (1.30 KB, patch)
2017-09-14 16:17 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-09-14 16:17:35 PDT
Created attachment 320839 [details] patch
Keith Miller
Comment 2 2017-09-14 16:18:15 PDT
Comment on attachment 320839 [details] patch r=me.
WebKit Commit Bot
Comment 3 2017-09-14 17:04:50 PDT
Comment on attachment 320839 [details] patch Clearing flags on attachment: 320839 Committed r222066: <http://trac.webkit.org/changeset/222066>
WebKit Commit Bot
Comment 4 2017-09-14 17:04:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:36:22 PDT
<rdar://problem/34693583>
Note You need to log in before you can comment on or make changes to this bug.