Bug 176931

Summary: [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, jer.noble, joepeck, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andy Estes 2017-09-14 11:31:58 PDT 
[Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
Comment 1 Andy Estes 2017-09-14 11:33:56 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2017-09-14 11:50:54 PDT 
Created attachment 320798 [details]
Patch
Comment 3 Joseph Pecoraro 2017-09-14 11:54:25 PDT 
Comment on attachment 320798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320798&action=review

rs=me

> Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:221
> +    // By default speech only returns a "premium" voices, which does not include all the

Grammar: "returns a premium voices" => "returns premium voices"
Comment 4 Andy Estes 2017-09-14 13:41:37 PDT 
Created attachment 320813 [details]
Patch
Comment 5 WebKit Commit Bot 2017-09-14 14:24:01 PDT 
Comment on attachment 320813 [details]
Patch

Clearing flags on attachment: 320813

Committed r222053: <http://trac.webkit.org/changeset/222053>
Comment 6 WebKit Commit Bot 2017-09-14 14:24:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:36:31 PDT 
<rdar://problem/34693591>