Bug 176931

Summary: [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, jer.noble, joepeck, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2017-09-14 11:31:58 PDT
[Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
Attachments
Patch (11.47 KB, patch)
2017-09-14 11:33 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (14.37 KB, patch)
2017-09-14 11:50 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (14.31 KB, patch)
2017-09-14 13:41 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-09-14 11:33:56 PDT Comment hidden (obsolete)
Andy Estes
Comment 2 2017-09-14 11:50:54 PDT
Created attachment 320798 [details] Patch
Joseph Pecoraro
Comment 3 2017-09-14 11:54:25 PDT
Comment on attachment 320798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320798&action=review rs=me > Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:221 > + // By default speech only returns a "premium" voices, which does not include all the Grammar: "returns a premium voices" => "returns premium voices"
Andy Estes
Comment 4 2017-09-14 13:41:37 PDT
Created attachment 320813 [details] Patch
WebKit Commit Bot
Comment 5 2017-09-14 14:24:01 PDT
Comment on attachment 320813 [details] Patch Clearing flags on attachment: 320813 Committed r222053: <http://trac.webkit.org/changeset/222053>
WebKit Commit Bot
Comment 6 2017-09-14 14:24:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:36:31 PDT
<rdar://problem/34693591>
Note You need to log in before you can comment on or make changes to this bug.