Bug 176907

Summary: [FreeType] Complex text is enabled too often after r221909
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, buildbot, csaavedra, mmaxfield, svillar, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2017-09-14 08:42:38 PDT
In r221909 we enabled complex text by default following the same cocoa ifdefs, but I forgot another ifdef in the cpp file. This is going to require another rebaseline fo 2200 tests. I hope it will be the last one.
Attachments
Patch (1.66 KB, patch)
2017-09-14 08:44 PDT, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-09-14 08:44:16 PDT
Created attachment 320769 [details] Patch
Carlos Garcia Campos
Comment 2 2017-09-15 00:08:36 PDT
Committed r222077: <http://trac.webkit.org/changeset/222077>
Claudio Saavedra
Comment 3 2017-09-15 03:06:44 PDT
After this change there's massive WPE test failure in the bots. Not sure what's going on.. https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/2820
Claudio Saavedra
Comment 4 2017-09-15 03:07:17 PDT
(In reply to Carlos Garcia Campos from comment #0) > In r221909 we enabled complex text by default following the same cocoa > ifdefs, but I forgot another ifdef in the cpp file. This is going to require > another rebaseline fo 2200 tests. I hope it will be the last one. > This is going to require another rebaseline fo 2200 tests. I hope it will be the last one. Ah, sorry. I should read before commenting.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:36:33 PDT
<rdar://problem/34693592>
Note You need to log in before you can comment on or make changes to this bug.