Bug 176886

Summary: [CMake] Detect harfbuzz without pkgconfig
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, buildbot, commit-queue, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2017-09-13 18:07:40 PDT
Currently harfbuzz is not able to be detected without pkgconfig which isn't typically used on windows.
Attachments
Patch (3.07 KB, patch)
2017-09-13 18:17 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2017-09-13 18:23 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-09-13 18:17:06 PDT
Created attachment 320718 [details] Patch Detects harfbuzz without pkgconfig. Will determine the version from the header file directly.
Build Bot
Comment 2 2017-09-13 18:20:16 PDT
Attachment 320718 [details] did not pass style-queue: ERROR: Source/cmake/FindHarfBuzz.cmake:54: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] ERROR: Source/cmake/FindHarfBuzz.cmake:55: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2017-09-13 18:23:28 PDT
Created attachment 320719 [details] Patch
WebKit Commit Bot
Comment 4 2017-09-13 23:19:12 PDT
Comment on attachment 320719 [details] Patch Clearing flags on attachment: 320719 Committed r222011: <http://trac.webkit.org/changeset/222011>
WebKit Commit Bot
Comment 5 2017-09-13 23:19:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:28:03 PDT
<rdar://problem/34693329>
Note You need to log in before you can comment on or make changes to this bug.