Bug 176867

Summary:

[JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, buildbot, commit-queue, jsbell, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	sam: review+
Patch	none

Yusuke Suzuki

Reported 2017-09-13 11:29:57 PDT

[JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray

Attachments
Patch (34.88 KB, patch) 2017-09-13 11:32 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (34.84 KB, patch) 2017-09-13 11:34 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (36.42 KB, patch) 2017-09-13 11:38 PDT, Yusuke Suzuki	sam: review+	Details Formatted Diff Diff
Patch (36.42 KB, patch) 2017-09-14 03:35 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2017-09-13 11:32:30 PDT

Created attachment 320663 [details] Patch

Build Bot

Comment 2 2017-09-13 11:33:37 PDT

Attachment 320663 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 3 2017-09-13 11:34:13 PDT

Created attachment 320664 [details] Patch

Yusuke Suzuki

Comment 4 2017-09-13 11:38:20 PDT

Created attachment 320666 [details] Patch

Yusuke Suzuki

Comment 5 2017-09-13 14:37:49 PDT

Comment on attachment 320666 [details] Patch Thanks!

Yusuke Suzuki

Comment 6 2017-09-14 03:35:26 PDT

Created attachment 320754 [details] Patch