Bug 176867 - [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
Summary: [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-13 11:29 PDT by Yusuke Suzuki
Modified: 2017-09-27 16:36 PDT (History)
11 users (show)

See Also:

Attachments
Patch (34.88 KB, patch)
2017-09-13 11:32 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (34.84 KB, patch)
2017-09-13 11:34 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (36.42 KB, patch)
2017-09-13 11:38 PDT, Yusuke Suzuki 		sam: review+
Details | Formatted Diff | Diff
Patch (36.42 KB, patch)
2017-09-14 03:35 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-09-13 11:29:57 PDT 
[JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
Comment 1 Yusuke Suzuki 2017-09-13 11:32:30 PDT 
Created attachment 320663 [details]
Patch
Comment 2 Build Bot 2017-09-13 11:33:37 PDT 
Attachment 320663 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2017-09-13 11:34:13 PDT 
Created attachment 320664 [details]
Patch
Comment 4 Yusuke Suzuki 2017-09-13 11:38:20 PDT 
Created attachment 320666 [details]
Patch
Comment 5 Yusuke Suzuki 2017-09-13 14:37:49 PDT 
Comment on attachment 320666 [details]
Patch

Thanks!
Comment 6 Yusuke Suzuki 2017-09-14 03:35:26 PDT 
Created attachment 320754 [details]
Patch
Comment 7 WebKit Commit Bot 2017-09-14 04:17:49 PDT 
Comment on attachment 320754 [details]
Patch

Clearing flags on attachment: 320754

Committed r222017: <http://trac.webkit.org/changeset/222017>
Comment 8 Radar WebKit Bug Importer 2017-09-27 16:36:45 PDT 
<rdar://problem/34701454>