Bug 176857

Summary: Add WKUIDelegatePrivate equivalent of WKPageUIClient's setIsResizable, getWindowFrame, and setWindowFrame
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, buildbot, cgarcia, gustavo, mcatanzaro, thisiskatewinslet, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2017-09-13 10:41:55 PDT
Add WKUIDelegatePrivate equivalent of WKPageUIClient's setIsResizable, getWindowFrame, and setWindowFrame
Attachments
Patch (17.73 KB, patch)
2017-09-13 10:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (16.70 KB, patch)
2017-09-13 11:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-13 10:43:45 PDT
Created attachment 320657 [details] Patch
Build Bot
Comment 2 2017-09-13 10:45:36 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Tim Horton
Comment 3 2017-09-13 11:13:46 PDT
Comment on attachment 320657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320657&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:167 > +- (void)_webView:(WKWebView *)webView setIsResizable:(BOOL)isResizable WK_API_AVAILABLE(macosx(WK_MAC_TBA)); This should likely be setResizeable, or possibly a didChange?, or something that someone smarter might suggest. "is" is for getters in Cocoaland.
Alex Christensen
Comment 4 2017-09-13 11:36:31 PDT
Created attachment 320665 [details] Patch
Alex Christensen
Comment 5 2017-09-13 11:38:25 PDT
http://trac.webkit.org/r221982
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:30:58 PDT
<rdar://problem/34693412>
Note You need to log in before you can comment on or make changes to this bug.