Bug 176853

Summary:

spindumps created on Mac/ios testers are very large

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Lucas Forschler <lforschler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, buildbot, dean_johnson, jbedard, lforschler, thisiskatewinslet, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
v1 patch for review	lforschler: commit-queue-
correct ChangeLog to include the bugzilla entry	aakash_jain: review+, lforschler: commit-queue-

Lucas Forschler

Reported 2017-09-13 10:28:23 PDT

Some Mac and iOS testers include spindumps. These are very large when extracted out to the results folder on build.webkit.org. (multiple terabytes) We should leave these compressed on disk. simply pre-compressing them on the client, before we create the results archive would be sufficient.

Attachments
v1 patch for review (3.08 KB, patch) 2017-09-13 10:29 PDT, Lucas Forschler	lforschler: commit-queue-	Details Formatted Diff Diff
correct ChangeLog to include the bugzilla entry (3.10 KB, patch) 2017-09-13 10:35 PDT, Lucas Forschler	aakash_jain: review+ lforschler: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Lucas Forschler

Comment 1 2017-09-13 10:28:45 PDT

<rdar://problem/34397653>

Lucas Forschler

Comment 2 2017-09-13 10:29:06 PDT

Created attachment 320654 [details] v1 patch for review

Build Bot

Comment 3 2017-09-13 10:30:43 PDT

Attachment 320654 [details] did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Lucas Forschler

Comment 4 2017-09-13 10:35:03 PDT

Created attachment 320655 [details] correct ChangeLog to include the bugzilla entry

Aakash Jain

Comment 5 2017-09-13 12:48:59 PDT

Comment on attachment 320655 [details] correct ChangeLog to include the bugzilla entry View in context: https://bugs.webkit.org/attachment.cgi?id=320655&action=review looks good assuming you have tested it. > Tools/BuildSlaveSupport/test-result-archive:50 > + shutil.copyfileobj(f_in, f_out) does this compress the file?

Lucas Forschler

Comment 6 2017-09-13 12:51:28 PDT

Comment on attachment 320655 [details] correct ChangeLog to include the bugzilla entry View in context: https://bugs.webkit.org/attachment.cgi?id=320655&action=review >> Tools/BuildSlaveSupport/test-result-archive:50 >> + shutil.copyfileobj(f_in, f_out) > > does this compress the file? Yes... this is straight from the python docs, so it seems to be the standard way of doing it. https://docs.python.org/2/library/gzip.html

Lucas Forschler

Comment 7 2017-09-13 12:54:22 PDT

Committed revision 221985.

Note You need to log in before you can comment on or make changes to this bug.