Bug 176827

Summary: Web Inspector: move Console.addInspectedNode to DOM.setInspectedNode
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, thisiskatewinslet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170570
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2017-09-13 01:34:00 PDT
This would allow us to tighten when we send specific information about nodes to the frontend to only for the selected node.
Attachments
Patch (44.50 KB, patch)
2017-09-18 11:34 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (44.17 KB, patch)
2017-09-25 17:15 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-09-18 11:34:01 PDT
Created attachment 321116 [details] Patch
Build Bot
Comment 2 2017-09-18 11:36:56 PDT
Attachment 321116 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:207: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 3 2017-09-25 11:46:03 PDT
Comment on attachment 321116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321116&action=review r=me, very nice! > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:61 > + get inspectedNode() { return this._inspectedNode; } Is this actually used? inspectedNode/_inspectedNode other than an early return in `setInspectedNode()`? Given that `setInspectedNode` doesn't populate it until a callback, I'd expect clients to have a hard time using this, since it would be wrong immediately after someone sets the value. I think we should drop this. > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:537 > + // COMPATIBILITY (iOS 11): DOM.setInspectedNode did not exist. > + if (!DOMAgent.setInspectedNode) { Well done!
Devin Rousso
Comment 4 2017-09-25 17:15:26 PDT
Created attachment 321777 [details] Patch
WebKit Commit Bot
Comment 5 2017-09-25 18:40:34 PDT
Comment on attachment 321777 [details] Patch Clearing flags on attachment: 321777 Committed r222486: <http://trac.webkit.org/changeset/222486>
WebKit Commit Bot
Comment 6 2017-09-25 18:40:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:28:58 PDT
<rdar://problem/34693354>
Note You need to log in before you can comment on or make changes to this bug.