Bug 176820

Summary: [WPE] Test fast/dom/Document/CaretRangeFromPoint/replace-element.html fails since r221909
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WPE WebKitAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, Ms2ger, thisiskatewinslet
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 156579    
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2017-09-12 17:53:34 PDT
The diff is the following: --- /home/clopez/webkit/wpe/layout-test-results/fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt +++ /home/clopez/webkit/wpe/layout-test-results/fast/dom/Document/CaretRangeFromPoint/replace-element-actual.txt @@ -1,6 +1,6 @@ Testing left of the image PASS: range.startContainer == image.previousSibling. -PASS: range.startOffset == 34. +FAIL: range.startOffset == 35. Testing right of the image PASS: range.startContainer == image.nextSibling. PASS: range.startOffset == 1. Not sure if this needs a rebaseline (with the FAIL string, ugly), the test needs to be reworked to be less sensive to the offset or it indicates a real failure caused by r221909.
Attachments
Patch (1.48 KB, patch)
2017-11-23 04:36 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-11-23 04:36:17 PST
Created attachment 327495 [details] Patch
WebKit Commit Bot
Comment 2 2017-11-23 05:09:30 PST
Comment on attachment 327495 [details] Patch Clearing flags on attachment: 327495 Committed r225114: <https://trac.webkit.org/changeset/225114>
WebKit Commit Bot
Comment 3 2017-11-23 05:09:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.