Bug 176783

Summary: [css-grid] Stretching auto tracks should be done as part of the track sizing algorithm
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jfernandez, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: BlinkMergeCandidate, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=763386
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch none

Description Manuel Rego Casasnovas 2017-09-12 07:27:46 PDT
CSS WG has agreed to modify the track sizing algorithm to include a new step: https://drafts.csswg.org/css-grid/#algo-stretch

We used to do the stretch of the "auto" tracks at the end of the track sizing algorithm, however the change integrates this into the algorithm itself as the last step.

See: https://github.com/w3c/csswg-drafts/issues/1150
Comment 1 Manuel Rego Casasnovas 2017-09-12 07:37:10 PDT
Created attachment 320547 [details]
Patch
Comment 2 Sergio Villar Senin 2017-09-12 09:32:13 PDT
Comment on attachment 320547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320547&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1077
> +    std::optional<LayoutUnit> currentFreeSpace = freeSpace(m_direction);

auto currentFreeSpace
Comment 3 Manuel Rego Casasnovas 2017-09-12 11:49:04 PDT
Created attachment 320557 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2017-09-12 11:49:43 PDT
Thanks for the review.

(In reply to Sergio Villar Senin from comment #2)
> Comment on attachment 320547 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320547&action=review
> 
> > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1077
> > +    std::optional<LayoutUnit> currentFreeSpace = freeSpace(m_direction);
> 
> auto currentFreeSpace

Ack.
Comment 5 WebKit Commit Bot 2017-09-12 12:19:51 PDT
Comment on attachment 320557 [details]
Patch

Clearing flags on attachment: 320557

Committed r221931: <http://trac.webkit.org/changeset/221931>
Comment 6 WebKit Commit Bot 2017-09-12 12:19:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:33:15 PDT
<rdar://problem/34693473>