Summary: | [css-grid] Stretching auto tracks should be done as part of the track sizing algorithm | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, jfernandez, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=763386 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 60731 | ||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2017-09-12 07:27:46 PDT
Created attachment 320547 [details]
Patch
Comment on attachment 320547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320547&action=review > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1077 > + std::optional<LayoutUnit> currentFreeSpace = freeSpace(m_direction); auto currentFreeSpace Created attachment 320557 [details]
Patch
Thanks for the review. (In reply to Sergio Villar Senin from comment #2) > Comment on attachment 320547 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320547&action=review > > > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1077 > > + std::optional<LayoutUnit> currentFreeSpace = freeSpace(m_direction); > > auto currentFreeSpace Ack. Comment on attachment 320557 [details] Patch Clearing flags on attachment: 320557 Committed r221931: <http://trac.webkit.org/changeset/221931> All reviewed patches have been landed. Closing bug. |