Bug 176777 – Disallow passing null data to uniform1uiv() and friends.

• Component: WebGL
• Status: RESOLVED FIXED

[Ms2ger (he/him; ⌚ UTC+1/+2)]

This matches the specification as well as Gecko and Chromium.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 320534 [details]
Patch

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 320536 [details]
Patch

Removed an accidental tab.

[Konstantin Tokarev]

Comment on attachment 320536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320536&action=review

> LayoutTests/fast/canvas/webgl/webgl2/bindings.html:10
> +  window.internals.settings.setWebGL2Enabled(true);

AFAIK we use 4-space indentation, though I dunno if that's required in layout tests or not

[Adrian Perez]

Comment on attachment 320536 [details]
Patch

Informal review r+

Good catch! With this change the functions certainly match the spec as currently
available at https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7

[Build Bot]

Comment on attachment 320536 [details]
Patch

Attachment 320536 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4523408

New failing tests:
fast/canvas/webgl/webgl2/bindings.html

[Build Bot]

Created attachment 320542 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 320536 [details]
Patch

Attachment 320536 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4523422

New failing tests:
fast/canvas/webgl/webgl2/bindings.html

[Build Bot]

Created attachment 320543 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 320544 [details]
Patch

Fixed paths.

[WebKit Commit Bot]

Comment on attachment 320544 [details]
Patch

Clearing flags on attachment: 320544

Committed r221915: <http://trac.webkit.org/changeset/221915>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34694016>