Bug 176740

Summary:

[Cleanup] Follow up cleanup for DOMFormData implementation

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cdumez, commit-queue, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Sam Weinig

Reported 2017-09-11 14:32:27 PDT

[Cleanup] Follow up cleanup for DOMFormData implementation

Attachments
Patch (68.88 KB, patch) 2017-09-11 21:11 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (68.90 KB, patch) 2017-09-11 21:14 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-09-11 21:11:36 PDT Comment hidden (obsolete)

Created attachment 320513 [details] Patch

Build Bot

Comment 2 2017-09-11 21:12:57 PDT Comment hidden (obsolete)

Attachment 320513 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/FormData.cpp:251: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2017-09-11 21:13:22 PDT

DOMFormData unfortunately needs to maintain its TextEncoding member, as it is used by HiddenInputType::appendFormData(...).

Sam Weinig

Comment 4 2017-09-11 21:14:25 PDT

Created attachment 320514 [details] Patch

Alex Christensen

Comment 5 2017-09-11 22:33:58 PDT

Comment on attachment 320514 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320514&action=review > Source/WTF/wtf/KeyValuePair.h:56 > + KeyType key; > + ValueType value { }; Do we intentionally want to keep no default initializer list for key?

Sam Weinig

Comment 6 2017-09-12 07:24:41 PDT

(In reply to Alex Christensen from comment #5) > Comment on attachment 320514 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320514&action=review > > > Source/WTF/wtf/KeyValuePair.h:56 > > + KeyType key; > > + ValueType value { }; > > Do we intentionally want to keep no default initializer list for key? I found this really odd, but didn’t want to change it in this patch.

WebKit Commit Bot

Comment 7 2017-09-12 07:53:22 PDT

Comment on attachment 320514 [details] Patch Clearing flags on attachment: 320514 Committed r221914: <http://trac.webkit.org/changeset/221914>

WebKit Commit Bot

Comment 8 2017-09-12 07:53:23 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2017-09-27 12:38:55 PDT

<rdar://problem/34693683>

Note You need to log in before you can comment on or make changes to this bug.