Bug 176683

Summary: Remove unnecessary virtual keyword from JS test files
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: New BugsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, darin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Frédéric Wang (:fredw)
Reported 2017-09-11 00:02:02 PDT
Remove unnecessary virtual keyword from JS test files
Attachments
Patch (10.46 KB, patch)
2017-09-11 00:04 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (12.08 KB, patch)
2017-09-11 01:25 PDT, Frédéric Wang (:fredw) 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2017-09-11 00:04:46 PDT
Created attachment 320418 [details] Patch
Build Bot
Comment 2 2017-09-11 00:07:59 PDT
Comment on attachment 320418 [details] Patch Attachment 320418 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4509987 New failing tests: (JS) JSTestCallbackFunction.h (JS) JSTestCallbackFunctionRethrow.h (JS) JSTestCallbackFunctionWithThisObject.h (JS) JSTestCallbackFunctionWithTypedefs.h (JS) JSTestCallbackInterface.h (JS) JSTestVoidCallbackFunction.h
Frédéric Wang (:fredw)
Comment 3 2017-09-11 01:25:03 PDT
Created attachment 320420 [details] Patch
Frédéric Wang (:fredw)
Comment 4 2017-09-12 00:37:03 PDT
Committed r221908: <http://trac.webkit.org/changeset/221908>
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:42:58 PDT
<rdar://problem/34693817>
Note You need to log in before you can comment on or make changes to this bug.