Bug 176671

Summary: Refactor Document::updateTitleElement to use traits instead of function pointers
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, koivisto, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2017-09-10 11:51:55 PDT
Refactor Document::updateTitleElement to use traits instead of function pointers
Attachments
Patch (5.54 KB, patch)
2017-09-10 11:54 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-09-10 11:54:08 PDT
Created attachment 320399 [details] Patch
Darin Adler
Comment 2 2017-09-10 13:38:39 PDT
Seems like too much attention for a small amount of code, but I could not resist. Antti, maybe this is even better than the last version?
Antti Koivisto
Comment 3 2017-09-10 15:05:02 PDT
Comment on attachment 320399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320399&action=review > Source/WebCore/dom/Document.cpp:1545 > +template<typename> struct TitleTraits; I feel using templates to implement two not-very-complicated cases is bit much but it is an improvement.
WebKit Commit Bot
Comment 4 2017-09-10 15:18:03 PDT
Comment on attachment 320399 [details] Patch Clearing flags on attachment: 320399 Committed r221838: <http://trac.webkit.org/changeset/221838>
WebKit Commit Bot
Comment 5 2017-09-10 15:18:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:32:58 PDT
<rdar://problem/34693468>
Note You need to log in before you can comment on or make changes to this bug.