Summary: | REGRESSION: [GTK] Generated HTML API documentation is missing descriptions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, berto, bugs-noreply, buildbot, gustavo, mcatanzaro | ||||
Priority: | P2 | Keywords: | Gtk, Regression | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-09-10 02:15:03 PDT
Created attachment 320391 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API I've re-generated the docs for 2.17.92 after applying this patch: https://webkitgtk.org/reference/webkit2gtk/2.17.92/WebKitWebView.html#webkit-web-view-new Comment on attachment 320391 [details]
Patch
Informal r+
Once we figure out how are we going to generate documentation for WPE, we
may need to do something similar adding the files with “WPE.cpp” suffix
(but we are not at that point just yet).
Comment on attachment 320391 [details]
Patch
Well this is Tools/gtk/generate/gtkdoc, so we don't need to consider WPE here. We'll indeed have to add WPE support soon, and move the script to Tools/Scripts.
Committed r221847: <http://trac.webkit.org/changeset/221847> |