| Summary: | Add WKUIDelegatePrivate equivalent of WKPageUIClient's decidePolicyForGeolocationPermissionRequest | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | berto, buildbot, cgarcia, darin, gustavo, mcatanzaro, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2017-09-08 17:52:55 PDT
Created attachment 320321 [details]
Patch
Created attachment 320358 [details]
Patch
Comment on attachment 320358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320358&action=review > Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:337 > +Function<void(bool)> UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest(WebKit::WebPageProxy&, WebKit::WebFrameProxy& frame, API::SecurityOrigin& securityOrigin, Function<void(bool)>&& completionHandler) As I mentioned in the other patch, I see no reason for the return value. We pass in a reference to a completion handler, and we null it out / move it out if we call it, so no need to also move it into a return value. Created attachment 320451 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API |