Bug 176642

Summary: Add WKUIDelegatePrivate equivalent of WKPageUIClient's decidePolicyForGeolocationPermissionRequest
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, buildbot, cgarcia, darin, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2017-09-08 17:52:55 PDT
Add WKUIDelegatePrivate equivalent of WKPageUIClient's decidePolicyForGeolocationPermissionRequest
Attachments
Patch (14.08 KB, patch)
2017-09-08 17:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.32 KB, patch)
2017-09-09 14:31 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (22.50 KB, patch)
2017-09-11 11:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-08 17:54:15 PDT
Created attachment 320321 [details] Patch
Alex Christensen
Comment 2 2017-09-09 14:31:56 PDT
Created attachment 320358 [details] Patch
Darin Adler
Comment 3 2017-09-10 14:54:57 PDT
Comment on attachment 320358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320358&action=review > Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:337 > +Function<void(bool)> UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest(WebKit::WebPageProxy&, WebKit::WebFrameProxy& frame, API::SecurityOrigin& securityOrigin, Function<void(bool)>&& completionHandler) As I mentioned in the other patch, I see no reason for the return value. We pass in a reference to a completion handler, and we null it out / move it out if we call it, so no need to also move it into a return value.
Alex Christensen
Comment 4 2017-09-11 11:54:37 PDT
Created attachment 320451 [details] Patch
Build Bot
Comment 5 2017-09-11 11:55:34 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 6 2017-09-11 13:45:40 PDT
http://trac.webkit.org/r221873
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:33:34 PDT
<rdar://problem/34693485>
Note You need to log in before you can comment on or make changes to this bug.