Bug 176638

Summary: [Cocoa] Add a modern WKPreferences switch to disable WebRTC
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, thorton, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description mitz 2017-09-08 16:48:28 PDT 
<rdar://problem/34335158>
We should have a modern equivalent of WKPreferencesSetPeerConnectionEnabled.
Comment 1 youenn fablet 2017-09-26 11:15:30 PDT 
Created attachment 321846 [details]
Patch
Comment 2 Tim Horton 2017-09-26 11:44:45 PDT 
Comment on attachment 321846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321846&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:105
> +@property (nonatomic, setter=_setPeerConnectionEnabled:) BOOL _peerConnectionEnabled WK_API_AVAILABLE(macosx(10.13), ios(11.0));

Given that they have shipped, I don't think this can possibly be available in 10.13 or 11.0. Use the WK_TBA magic.
Comment 3 youenn fablet 2017-09-26 11:47:50 PDT 
Created attachment 321852 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-26 16:35:44 PDT 
Comment on attachment 321852 [details]
Patch

Clearing flags on attachment: 321852

Committed r222533: <http://trac.webkit.org/changeset/222533>
Comment 5 WebKit Commit Bot 2017-09-26 16:35:46 PDT 
All reviewed patches have been landed.  Closing bug.