Web Inspector: make split console full width of view

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Instead of limiting the split console's width to just the main content area (non-sidebar space), we should consider widening it to cover the entire width.  This way, if both sidebars are visible, the console is not as "squished".

[Devin Rousso]

Created attachment 320310 [details]
Patch

[Devin Rousso]

Created attachment 320311 [details]
[Image] split console expanded

[Joseph Pecoraro]

What does it look like when collapsed?

[Devin Rousso]

Created attachment 320313 [details]
[Image] split console collapsed

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #4)
> Created attachment 320313 [details]
> [Image] split console collapsed

I can't help but notice you chose the tab that has a single sidebar showing. This looks a little weird but it doesn't look too bad. It certainly breaks some of the aesthetics.

[Matt Baker]

(In reply to Devin Rousso from comment #2)
> Created attachment 320311 [details]
> [Image] split console expanded

Our current filter bar placement probably prevents us from making this change as is. I like the full width console, but would have to give more thought to how to resolve the aesthetic issues.

[Devin Rousso]

(In reply to Matt Baker from comment #6)
> (In reply to Devin Rousso from comment #2)
> > Created attachment 320311 [details]
> > [Image] split console expanded
> 
> Our current filter bar placement probably prevents us from making this
> change as is. I like the full width console, but would have to give more
> thought to how to resolve the aesthetic issues.
Do you mean the FilterBar in the NavigationSidebar, or the FilterBar present in the Console tab?  I'm assuming the former since the Console's FilterBar isn't visible in the split console currently.

How does this prevent the change?  I think the visual distinction (especially when the SplitConsole is collapsed) is quite clear.  There is a huge benefit of having a full width console, especially in a tab like Debugger where both Sidebar are very useful (Breakpoints and Scope Chain).

[Timothy Hatcher]

Interesting. The white background on the filter bar in the styles sidebar should be grey to match the sidebar background color now that it does not line up with the console input bar.

[Devin Rousso]

Created attachment 323759 [details]
Patch

[Devin Rousso]

Created attachment 323760 [details]
[Image] split console expanded (Resources)

[Devin Rousso]

Created attachment 323762 [details]
[Image] split console collapsed (Resources)

[Devin Rousso]

Created attachment 323763 [details]
[Image] split console collapsed (Elements)

[WebKit Commit Bot]

Comment on attachment 323759 [details]
Patch

Clearing flags on attachment: 323759

Committed r223310: <https://trac.webkit.org/changeset/223310>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34989944>

[Nikita Vasilyev]

Created attachment 323811 [details]
[Image] Regression

This broke the class list container. Should be an easy fix.