Bug 176635

Summary:

Web Inspector: make split console full width of view

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
[Image] split console expanded	none
[Image] split console collapsed	none
Patch	none
[Image] split console expanded (Resources)	none
[Image] split console collapsed (Resources)	none
[Image] split console collapsed (Elements)	none
[Image] Regression	none

Devin Rousso

Reported 2017-09-08 15:26:17 PDT

Instead of limiting the split console's width to just the main content area (non-sidebar space), we should consider widening it to cover the entire width. This way, if both sidebars are visible, the console is not as "squished".

Attachments
Patch (2.31 KB, patch) 2017-09-08 15:29 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] split console expanded (204.33 KB, image/png) 2017-09-08 15:29 PDT, Devin Rousso	no flags	Details
[Image] split console collapsed (116.43 KB, image/png) 2017-09-08 16:29 PDT, Devin Rousso	no flags	Details
Patch (3.53 KB, patch) 2017-10-13 16:05 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] split console expanded (Resources) (579.79 KB, image/png) 2017-10-13 16:05 PDT, Devin Rousso	no flags	Details
[Image] split console collapsed (Resources) (584.78 KB, image/png) 2017-10-13 16:06 PDT, Devin Rousso	no flags	Details
[Image] split console collapsed (Elements) (554.80 KB, image/png) 2017-10-13 16:06 PDT, Devin Rousso	no flags	Details
[Image] Regression (55.66 KB, image/png) 2017-10-14 11:18 PDT, Nikita Vasilyev	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-09-08 15:29:19 PDT

Created attachment 320310 [details] Patch

Devin Rousso

Comment 2 2017-09-08 15:29:47 PDT

Created attachment 320311 [details] [Image] split console expanded

Joseph Pecoraro

Comment 3 2017-09-08 16:23:45 PDT

What does it look like when collapsed?

Devin Rousso

Comment 4 2017-09-08 16:29:13 PDT

Created attachment 320313 [details] [Image] split console collapsed

Joseph Pecoraro

Comment 5 2017-09-08 16:56:41 PDT

(In reply to Devin Rousso from comment #4) > Created attachment 320313 [details] > [Image] split console collapsed I can't help but notice you chose the tab that has a single sidebar showing. This looks a little weird but it doesn't look too bad. It certainly breaks some of the aesthetics.

Matt Baker

Comment 6 2017-09-21 15:45:13 PDT

(In reply to Devin Rousso from comment #2) > Created attachment 320311 [details] > [Image] split console expanded Our current filter bar placement probably prevents us from making this change as is. I like the full width console, but would have to give more thought to how to resolve the aesthetic issues.

Devin Rousso

Comment 7 2017-09-21 16:50:14 PDT

(In reply to Matt Baker from comment #6) > (In reply to Devin Rousso from comment #2) > > Created attachment 320311 [details] > > [Image] split console expanded > > Our current filter bar placement probably prevents us from making this > change as is. I like the full width console, but would have to give more > thought to how to resolve the aesthetic issues. Do you mean the FilterBar in the NavigationSidebar, or the FilterBar present in the Console tab? I'm assuming the former since the Console's FilterBar isn't visible in the split console currently. How does this prevent the change? I think the visual distinction (especially when the SplitConsole is collapsed) is quite clear. There is a huge benefit of having a full width console, especially in a tab like Debugger where both Sidebar are very useful (Breakpoints and Scope Chain).

Timothy Hatcher

Comment 8 2017-10-13 09:32:08 PDT

Interesting. The white background on the filter bar in the styles sidebar should be grey to match the sidebar background color now that it does not line up with the console input bar.

Devin Rousso

Comment 9 2017-10-13 16:05:13 PDT

Created attachment 323759 [details] Patch

Devin Rousso

Comment 10 2017-10-13 16:05:43 PDT

Created attachment 323760 [details] [Image] split console expanded (Resources)

Devin Rousso

Comment 11 2017-10-13 16:06:02 PDT

Created attachment 323762 [details] [Image] split console collapsed (Resources)

Devin Rousso

Comment 12 2017-10-13 16:06:18 PDT

Created attachment 323763 [details] [Image] split console collapsed (Elements)

WebKit Commit Bot

Comment 13 2017-10-13 17:05:11 PDT

Comment on attachment 323759 [details] Patch Clearing flags on attachment: 323759 Committed r223310: <https://trac.webkit.org/changeset/223310>

WebKit Commit Bot

Comment 14 2017-10-13 17:05:12 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2017-10-13 17:06:10 PDT

<rdar://problem/34989944>

Nikita Vasilyev

Comment 16 2017-10-14 11:18:39 PDT

Created attachment 323811 [details] [Image] Regression This broke the class list container. Should be an easy fix.

Note You need to log in before you can comment on or make changes to this bug.