Bug 176630

Summary:

REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, jfbastien, jlewis3, mark.lam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	jfbastien: review+

Ryan Haddad

Reported 2017-09-08 13:55:48 PDT

** The following JSC stress test failures have been introduced: stress/op_mod-ConstVar.js.misc-ftl-no-cjit stress/op_mod-VarConst.js.misc-ftl-no-cjit stress/op_mod-VarVar.js.misc-ftl-no-cjit https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20%28Tests%29/builds/971

Attachments
proposed patch. (3.98 KB, patch) 2017-09-12 12:42 PDT, Mark Lam	jfbastien: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryan Haddad

Comment 1 2017-09-08 14:00:18 PDT

Looking at the regression range, this may be related to https://trac.webkit.org/changeset/221774/webkit

Ryan Haddad

Comment 2 2017-09-08 14:00:50 PDT

(In reply to Ryan Haddad from comment #1) > Looking at the regression range, this may be related to > https://trac.webkit.org/changeset/221774/webkit *The regression range being r221773 - r221779

Mark Lam

Comment 3 2017-09-09 09:51:20 PDT

I'll break these tests into smaller chunks.

Ryan Haddad

Comment 4 2017-09-12 09:31:27 PDT

The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/1476

Mark Lam

Comment 5 2017-09-12 09:50:06 PDT

(In reply to Ryan Haddad from comment #4) > The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > bit%20JSC%20%28BuildAndTest%29/builds/1476 These are for op_div (not op_mod). Anyway, let me trying increasing their timeout allowance and see if that helps.

Ryan Haddad

Comment 6 2017-09-12 10:18:42 PDT

(In reply to Mark Lam from comment #5) > (In reply to Ryan Haddad from comment #4) > > The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): > > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > > bit%20JSC%20%28BuildAndTest%29/builds/1476 > > These are for op_div (not op_mod). Anyway, let me trying increasing their > timeout allowance and see if that helps. Oops, sorry for missing that detail.

Mark Lam

Comment 7 2017-09-12 12:42:57 PDT

Created attachment 320562 [details] proposed patch.

JF Bastien

Comment 8 2017-09-12 12:44:17 PDT

Comment on attachment 320562 [details] proposed patch. r=me

Mark Lam

Comment 9 2017-09-12 12:47:35 PDT

Thanks for the review. Landed in r221935: <http://trac.webkit.org/r221935>.

Radar WebKit Bug Importer

Comment 10 2017-09-27 12:33:53 PDT

<rdar://problem/34693492>

Note You need to log in before you can comment on or make changes to this bug.