Summary: | REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, jfbastien, jlewis3, mark.lam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2017-09-08 13:55:48 PDT
Looking at the regression range, this may be related to https://trac.webkit.org/changeset/221774/webkit (In reply to Ryan Haddad from comment #1) > Looking at the regression range, this may be related to > https://trac.webkit.org/changeset/221774/webkit *The regression range being r221773 - r221779 I'll break these tests into smaller chunks. The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/1476 (In reply to Ryan Haddad from comment #4) > The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > bit%20JSC%20%28BuildAndTest%29/builds/1476 These are for op_div (not op_mod). Anyway, let me trying increasing their timeout allowance and see if that helps. (In reply to Mark Lam from comment #5) > (In reply to Ryan Haddad from comment #4) > > The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): > > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > > bit%20JSC%20%28BuildAndTest%29/builds/1476 > > These are for op_div (not op_mod). Anyway, let me trying increasing their > timeout allowance and see if that helps. Oops, sorry for missing that detail. Created attachment 320562 [details]
proposed patch.
Comment on attachment 320562 [details]
proposed patch.
r=me
Thanks for the review. Landed in r221935: <http://trac.webkit.org/r221935>. |