Bug 176619

Summary: [GTK] Improve Ctrl+W and Ctrl+Q shortcuts in MiniBrowser
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176587
Attachments:
Description Flags
Patch
cgarcia: review+
Patch
none
Patch none

Description Michael Catanzaro 2017-09-08 11:05:14 PDT 
In MiniBrowser, Ctrl+W closes the entire browser, but it should close only a single tab. It's been broken since support for multiple tabs was added.
Comment 1 Michael Catanzaro 2017-09-08 11:06:08 PDT 
Created attachment 320279 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-09-08 23:56:24 PDT 
Comment on attachment 320279 [details]
Patch

Shouldn't we try close here too?
Comment 3 Michael Catanzaro 2017-09-09 08:01:36 PDT 
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 320279 [details]
> Patch
> 
> Shouldn't we try close here too?

Um... yes. I wrote this patch first and didn't remember that try_close existed.

We should do it for Ctrl+Q as well.
Comment 4 Michael Catanzaro 2017-09-09 12:24:30 PDT 
Created attachment 320352 [details]
Patch
Comment 5 Michael Catanzaro 2017-09-09 12:28:16 PDT 
Created attachment 320353 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-10 02:54:35 PDT 
Comment on attachment 320353 [details]
Patch

Clearing flags on attachment: 320353

Committed r221833: <http://trac.webkit.org/changeset/221833>
Comment 7 WebKit Commit Bot 2017-09-10 02:54:36 PDT 
All reviewed patches have been landed.  Closing bug.