Summary: | Introduce a RecordData for Cache to efficiently check whether it matches a corresponding request or not | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, buildbot, cdumez, cgarcia, commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2017-09-07 19:10:27 PDT
Created attachment 320225 [details]
Patch
Attachment 320225 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 320225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320225&action=review > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46 > + uint64_t identifier { 0}; space Created attachment 320573 [details]
Patch for landing
Thanks for the review. (In reply to Alex Christensen from comment #3) > Comment on attachment 320225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320225&action=review > > > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46 > > + uint64_t identifier { 0}; > > space Done Attachment 320573 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 320573 [details] Patch for landing Clearing flags on attachment: 320573 Committed r221942: <http://trac.webkit.org/changeset/221942> All reviewed patches have been landed. Closing bug. |