Bug 176579

Summary: Introduce a RecordData for Cache to efficiently check whether it matches a corresponding request or not
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, cgarcia, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2017-09-07 19:10:27 PDT
This will be useful to store the information to check whether a record is matching before fully reading the record.
Comment 1 youenn fablet 2017-09-07 19:22:09 PDT
Created attachment 320225 [details]
Patch
Comment 2 Build Bot 2017-09-07 19:24:18 PDT
Attachment 320225 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-09-12 15:24:20 PDT
Comment on attachment 320225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320225&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46
> +    uint64_t identifier { 0};

space
Comment 4 youenn fablet 2017-09-12 15:43:10 PDT
Created attachment 320573 [details]
Patch for landing
Comment 5 youenn fablet 2017-09-12 15:43:36 PDT
Thanks for the review.

(In reply to Alex Christensen from comment #3)
> Comment on attachment 320225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320225&action=review
> 
> > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:46
> > +    uint64_t identifier { 0};
> 
> space

Done
Comment 6 Build Bot 2017-09-12 15:44:35 PDT
Attachment 320573 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/cache/DOMCacheEngine.h:51:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2017-09-12 16:13:20 PDT
Comment on attachment 320573 [details]
Patch for landing

Clearing flags on attachment: 320573

Committed r221942: <http://trac.webkit.org/changeset/221942>
Comment 8 WebKit Commit Bot 2017-09-12 16:13:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-09-27 12:37:03 PDT
<rdar://problem/34693609>