Bug 176561

Summary:

[PAL] Unify PlatformUserPreferredLanguages.h with Language.h

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for committing	none
Patch for committing	none

Myles C. Maxfield

Reported 2017-09-07 13:39:26 PDT

[PAL] Unify PlatformUserPreferredLanguages.h with Language.h

Attachments
Patch (92.74 KB, patch) 2017-09-07 13:49 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (93.24 KB, patch) 2017-09-07 14:01 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (93.40 KB, patch) 2017-09-07 14:20 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (96.47 KB, patch) 2017-09-07 14:32 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (96.64 KB, patch) 2017-09-07 14:38 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (99.07 KB, patch) 2017-09-07 14:45 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (99.40 KB, patch) 2017-09-07 15:25 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (99.98 KB, patch) 2017-09-07 15:36 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-09-07 13:49:48 PDT

Created attachment 320171 [details] Patch

Myles C. Maxfield

Comment 2 2017-09-07 14:01:42 PDT

Created attachment 320175 [details] Patch

Myles C. Maxfield

Comment 3 2017-09-07 14:20:57 PDT

Created attachment 320180 [details] Patch

Myles C. Maxfield

Comment 4 2017-09-07 14:32:00 PDT

Created attachment 320182 [details] Patch

Myles C. Maxfield

Comment 5 2017-09-07 14:38:58 PDT

Created attachment 320184 [details] Patch

Brent Fulgham

Comment 6 2017-09-07 14:44:32 PDT

Comment on attachment 320184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320184&action=review This change looks good, but I think you need to update some GTK-specific files: platform/text/enchant/TextCheckerEnchant.cpp:25:22: fatal error: Language.h: No such file or directory r=me, but no cq+ because there are some missing include corrections. > Source/WTF/wtf/CMakeLists.txt:233 > + Language.cpp Ha! You caught this. :-)

Brent Fulgham

Comment 7 2017-09-07 14:45:15 PDT

WPE: In file included from /home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp:35:0: DerivedSources/ForwardingHeaders/WebCore/Language.h:1:39: fatal error: WebCore/platform/Language.h: No such file or directory #include "WebCore/platform/Language.h"

Myles C. Maxfield

Comment 8 2017-09-07 14:45:42 PDT

Created attachment 320185 [details] Patch

Myles C. Maxfield

Comment 9 2017-09-07 15:25:18 PDT

Created attachment 320190 [details] Patch for committing

Myles C. Maxfield

Comment 10 2017-09-07 15:36:44 PDT

Created attachment 320191 [details] Patch for committing

WebKit Commit Bot

Comment 11 2017-09-07 16:11:25 PDT

Comment on attachment 320191 [details] Patch for committing Clearing flags on attachment: 320191 Committed r221768: <http://trac.webkit.org/changeset/221768>

WebKit Commit Bot

Comment 12 2017-09-07 16:11:27 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 13 2017-09-27 12:39:14 PDT

<rdar://problem/34693692>

Note You need to log in before you can comment on or make changes to this bug.